Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator

@rapha0311

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


The biggest difficulty found was related to the positioning of the elements in the css.

Community feedback

Loo_cee 230

@Loocee

Posted

Hi, maybe you could align the texts in the body to center

body { text align: center; }

I think you should also remove the height property from your container so it can adjust to changes

Add margin top and bottom to the content in your container excluding the button, so they can be evenly spaced.

Rather than leaving your page empty till the user clicks the button, I think you should add some content like Advice #117 as given in the design files.

I hope this helps and happy coding.

Marked as helpful

0

@rapha0311

Posted

@Loocee thank you for the tips! It's always nice to receive constructive criticism.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord