Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found

Submitted

Advice generator

@FilipApa

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hi Filip, congratulations on completing the challenge, great job! 😁

Some little tips for optimizing your code:

  • the best and correct use of the header tag is to wrap the navbar not a inside section of that one element... same for the footer tag but wrapping the last section of the page
  • use main tag to wrap all main content of the page and improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

Hope this help! Happy coding 😉

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord