Advice generator

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Filip, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • the best and correct use of the header tag is to wrap the navbar not a inside section of that one element... same for the footer tag but wrapping the last section of the page
  • use main tag to wrap all main content of the page and improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  1