Advice Generator

Community feedback

• 

  Faris P•2,810

  @FarisPalayiPosted over 2 years ago

  Hey, nice job on this one 👍. Here are some of my suggestions:

  • set the image alt values to alt="" if images are only used for decorative purposes
  • I think the alt value divider is unnecessary in the divider img because it doesn't provide any useful information or extra context. i.e. since it's decorative.
  • try adding a :focus state style to the button so that people using keyboard to navigate can use the site easily
  • set an aria-label attribute to the button so that the purpose of the button is clear to assistive devices.
  • also, try using the blockquote tag instead of the p for advice, to make the html semantic

  Happy coding ✨

  Marked as helpful

  0

  ---

  

  Manuela Fernandez•360

  @mafernandezgoPosted over 2 years ago

  @FarisPalayi Thank you for your comments, I will consider them

  1