Advice Generator

Community feedback

• 

  T

  Grace•31,530

  @grace-snowPosted 6 days ago

  This looks good, just a few small improvements to suggest:

  1. Instead of trying to set two competing assertive aria-live regions, wrap the whole card in ONE aria-live set to "polite". Because you have two at the moment they overrule each other, meaning only one will be announced. There is no reason why these would need to be assertive either.
  2. The Dice button label needs to begin with the word "dice" so that it is easy to activate for voice control users. E.g. "Dice - Generate new random advice". This is especially important as you've told people to click the dice button in the help text.
  3. It looks like this challenge intends for you to use the picture element for the divider images as different onese are provided for mobile vs desktop.

  Marked as helpful

  1

  ---

  

  P

  Øystein Håberg•11,380

  @Islandstone89Posted 5 days ago

  @grace-snow Thank you for the feedback!

  I did use the <picture> element for the divider, and I think it works as intended?

  I've updated the aria-label on the button, and added aria-live="polite" to the whole card, with aria-live="assertive" removed. The reason I added it was I thought screen readers should stop speaking out the quote when another quote is generated.

  0
• 

  Dylan Heslop•2,360

  @dylan-dot-cPosted 8 days ago

  This is a good solution, but thats why im here.

  I think(idk) that you are in jeopardy for getting 3rd place for mentor of the year and getting sidelined by the current 3rd place.

  I don't know if you care about the 3rd place and the free 1-year fem premium but I just wanted to let you know, and maybe try and help you if you actually care about it in some way.

  Just a random guy tho.

  Also checko out my solution and tell me what you think.

  Marked as helpful

  1

  ---

  

  P

  Øystein Håberg•11,380

  @Islandstone89Posted 8 days ago

  @dylan-dot-c Hi! Hehe, yeah I've been in the top 3 for a while. Would like to get it, but if someone's posting a large amount of helpful comments, fair play.

  Your solution looks great! Nice spinning animation on the button :)

  All the best

  0

  

  Dylan Heslop•2,360

  @dylan-dot-cPosted 8 days ago

  @Islandstone89 thanks!

  Yh that is true tho, like last month I was competing for mentor of the month and in the last week, he came out of no where and stole 1st place from me... I was so upset, but if he's helping the community, its fair game as you said.

  In the end, giving valuable feedback is always an esteemed reward. Take care bro. Maybe next year...(hopefully, I'll be somewhere up there as well)

  Marked as helpful

  1