Advice generator

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Vittorio,

  Congratulations for 🎉 for completing your first challenge, the API looks great and is functional. It is great that you used the right semantic and the flex property to center the card. There are some suggestions I want to give:

  1. Your button is missing the type attribute
  2. Since you already gave your .container a max-width, you do not need to have a media query. Instead, you can give your body a margin property to prevent the card touching the side of the screen e.g. margin: 0 10px;
  3. Even though your API is functional on normal browsers, it won't work on Firefox without the clear cache e.g. fetch(URL, {cache: 'no-cache'})

  Overall, great work and wish you the best for your future projects 👍.

  0