romila• 3,570
@romila2003
Posted
Hi Vittorio,
Congratulations for 🎉 for completing your first challenge, the API looks great and is functional. It is great that you used the right semantic and the flex
property to center the card. There are some suggestions I want to give:
- Your button is missing the
type
attribute - Since you already gave your
.container
amax-width
, you do not need to have a media query. Instead, you can give yourbody
amargin
property to prevent the card touching the side of the screen e.g.margin: 0 10px;
- Even though your API is functional on normal browsers, it won't work on Firefox without the clear cache e.g.
fetch(URL, {cache: 'no-cache'})
Overall, great work and wish you the best for your future projects 👍.
0