Design comparison
Solution retrospective
Not really proud of anything I made.
What challenges did you encounter, and how did you overcome them?Got an error while deploying to Netlify. Was able to fix it by importing Axios directly from node_modules.
import axios from '../node_modules/axios/index'
What specific areas of your project would you like help with?Not sure, but any feedback is good.
Community feedback
- @AdrianoEscarabotePosted 27 days ago
Hi Nathaniel Ravelo, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:
Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.
<h1>Welcome to Advice generator app</h1>
Consider using
rem
for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.if you want to continue coding with
px
, you can download a very useful extension in vscode, it convertspx
torem
!link -> px to rem
The rest is amazing.
I hope this is helpful. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord