Advice Generator

Community feedback

• 

  Adriano•38,350

  @AdrianoEscarabotePosted about 1 month ago

  Hi Nathaniel Ravelo, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:

  Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.

  <h1>Welcome to Advice generator app</h1>
  

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem!

  link -> px to rem

  The rest is amazing.

  I hope this is helpful. 👍

  0