Design comparison
Solution retrospective
Hi this is Fejiro, and this is my solution to the Advice Generator
- Got it as close to the design
- Made sure it was responsive
- Achieved perfect 100 score on lighthouse
Any suggestions on how I can improve are welcomed
Community feedback
- @StormKing969Posted about 1 year ago
Not sure if you noticed but you seem to be getting duplicate responses from your API call. to prevent that, you'll have to disable caching. Also I'd suggest that you put your call in a try catch methods. That way, you can log any error you get.
1@Fejiro001Posted about 1 year ago@StormKing969 thank you so much for the advice. I'll start on that
0 - @JJacobPRPosted about 1 year ago
Hey,
I love your dice animation. What I would improve is the random data generation. As this API tends to get a little bit sloppy, you can use the documentation to find route for a specific advice and generate the ids yourself in frontend to ensure that user would get random advice. I know that normally it would be backend's fault but here we are just practicing, aren't we 😀
1@Fejiro001Posted about 1 year ago@JJacobPR thank you for the review. I will try it out.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord