Advice generator app

Community feedback

• 

  AdrianH•190

  @Adrian-pyPosted over 2 years ago

  Hello there! First of all, I really like your solution to this project. After going through the source code and also checking out the live site itself, I still feel that there are several things that can be improved.

  1. File Organization When I first opened the GitHub repository, I saw that you placed all the CSS, Javascript, and SCSS files inside the assets folder. In my opinion, you should not do that, instead, you should create a separate folder to put your files in. In my experience, the assets folder only stores images, audio, or videos that are used.

  2. Separating SCSS Modules The way you separated the modules for "globals", "mixins", etc. is already really good, but I just want to suggest another way of separating your SASS/SCSS modules. Here is a link to a Github repository made by a content creator on Youtube called CoderCoder: https://github.com/thecodercoder/fem-dklt-toggle

  That is all from me and I am very sorry if there are many mistakes on my part.

  1

  ---

  

  MURRAY122•280

  @MURRAY122Posted over 2 years ago

  Hi @Adrian-py, Thanks for your feedback and suggestions. I looked at the GitHub repository you mentioned and really liked its structure. I'll look to adopt this kind of structure for the future.

  1