Advice Generator using React

Community feedback

• 

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  Hi Robert! your project looks nice and clean. About the advice being cached for 2 seconds and any repeated request within 2 seconds returning the same piece of advice, I ran into the same thing when I did this project, after a half-hour debug session trying to find why it was doing that I found this on the docs for the Advice Slip API they have a note that says - Note: Advice is cached for 2 seconds. Any repeat request within 2 seconds will return the same piece of advice.

  If you found this helpful please mark it as such :) Let's connect on LinkedIn! www.linkedin.com/in/eileen-dangelo

  Marked as helpful

  1

  ---

  

  Robert•300

  @romanrobertPosted almost 2 years ago

  @Eileenpk

  Hi Eileen, Thanks for the feedback, much appreciated. Linkedin request sent. Have a nice day and happy coding!

  0

  

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  @romanrobert request accepted 👍 If you ever need anything or want to team up on something (I've been thinking about trying pair programming) let me know.

  0
• 

  Rahul Baranwal•135

  @RahulbaranPosted almost 2 years ago

  Good evening/morning Robert, I am Rahul from Bharat(India). Here is my feedback:-

  • Use heading tag for large font-sizes (wrap quote in h1 tag instead of p).

  • CSS Custom properties are very handy and make your code maintainable. Learn to use them (An article by Smashing Magazine, if you are interesed to read)

  • Wrap dice image inside a <button> tag instead of <span>, since it is a button and you should keep accessiblity in mind.

  • Always use catch() along with then() to handle an error while making the request.

  • No need to import React in App.jsx.

  Marked as helpful

  0

  ---

  

  Robert•300

  @romanrobertPosted almost 2 years ago

  @Rahulbaran

  Hello Bharat,

  Thank you for the feedback, highly appreciated.

  0

  

  Rahul Baranwal•135

  @RahulbaranPosted almost 2 years ago

  @romanrobert , I am happy to know this.

  0