Advice Generator App with simple js codes

Community feedback

• 

  Jacky Du•100

  @jacky-uiPosted over 1 year ago

  I like that you coded the lines, dividers and dice!! If you don't mind, there are some things I recommend.

  -Be careful with setting justify-content:space-around; on your drawing class. This is because some of the generated quotes are bigger than others and with space-around, it will increase the spacing between your content, causing the line and pause div to be pulled apart. There are more than one solution, but why not try taking off justify-content from your drawings class, and apply the gap property instead? This will create a set gap between your divs within your drawing class. In addition to that, set your line class to width:100%;. Since you have already applied padding to your card class, the lines won't overflow.

  Marked as helpful

  1