Advice Generator App with SCSS and JavaScript

Community feedback

• 

  Oleg•350

  @o-gtkvPosted over 1 year ago

  Hi, Jakub

  Some tips on your code.

  <img class="patternDivider desktopOnly" src="images/pattern-divider-desktop.svg" alt="">

  <img class="patternDivider mobileOnly" src="images/pattern-divider-mobile.svg" alt="">

  You don't need css here, use the picture tag instead.

  <button class="diceButton"> <img src="images/icon-dice.svg" alt=""> </button>

  For images inside buttons you should always specify a non-empty alt attribute. This is important for accessibility purposes.

  Hope this helps. Happy coding!

  Marked as helpful

  0