Advice generator app with JS concepts like Async Await Fetch & Promise

Community feedback

• 

  Aman Singh Bhogal•1,010

  @asbhogalPosted over 1 year ago

  Hi Pranjali - this is a really good project, well done!

  I've noticed however than soon after the page renders, the container shifts to the bottom. This is due to the grid-template-rows: 1fr auto on the body which is adding another row above the container. If you remove this, it should now be shifted centrally (you also have display: grid listed twice in your stylesheet, you can omit one of them).

  The footer will still be above as before, but you can amend this by removing the grid-row-start and grid-row-end properties on the .footer. Also, you can remove the flex-shrink property, as this has no effect if display: flex isn't set.

  Hope this helps!

  Marked as helpful

  1