Advice generator app with html, css and js

Community feedback

• 

  Mo•840

  @MohamedAridahPosted over 2 years ago

  Hello @sanketcharanpahadi, you solution is looking very good.👍👏

  I have some feedback for you:

  • you can run getQuote() function when page loads for getting new advice every time.

  window.addEventListener('load', getQuote);
  

  • you can use button instead of .expand div. It will be more Semantic.

  <button class="expand flex">
        <img src="images/icon-dice.svg" alt="">
  </button>
  

  just add this property to the .expand

  .expand {
      all: unset
  }
  

  I hope this wasn't too long for you, hoping also it was useful😍.

  Goodbye and have a nice day.

  Keep coding🚀

  Marked as helpful

  1
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of h1 to be more semantic

  i hope this is helpful and goodluck!

  Marked as helpful

  1