Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator app with API

Amr 710

@amrmabdelazeem

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Issue with the icon dice fixed. New hovering states animation added.

Community feedback

Bryan Li 3,550

@Zy8712

Posted

Hi there! To answer your question: In order to position the divider and the dice button you should use position: absolute on them. Then you should use position: relative on their parent which in this case is the div with class .container. Then you can use the bottom css property to position it. Read more about position: absolute here and more about bottom here.

Some other things I noticed when testing you site and reading you code:

  • the dice button doesn't cause the advice text to be replaced
  • <footer> tags should mainly be used for things at the very bottom of web-pages and aren't apart of the page's main content
  • <section> tags should mainly be used for long webpages with different sections, each with different topics
  • you should replace the <footer> and <section> tags with standard <div> tags

Hope you find this feedback useful 👍

Marked as helpful

0

Amr 710

@amrmabdelazeem

Posted

@Zy8712 Thank you for your response! I'll replace the semantic tags with divs, I also known I can use absolute and add the parent to relative but I don't know how I missed it!

Also seems like I missed adding brains to the dice to change the adivce and only left it to refreshing the page, will be working on that very soon.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord