Advice Generator app with API

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted 12 months ago

  Hi there! To answer your question: In order to position the divider and the dice button you should use position: absolute on them. Then you should use position: relative on their parent which in this case is the div with class .container. Then you can use the bottom css property to position it. Read more about position: absolute here and more about bottom here.

  Some other things I noticed when testing you site and reading you code:

  • the dice button doesn't cause the advice text to be replaced
  • <footer> tags should mainly be used for things at the very bottom of web-pages and aren't apart of the page's main content
  • <section> tags should mainly be used for long webpages with different sections, each with different topics
  • you should replace the <footer> and <section> tags with standard <div> tags

  Hope you find this feedback useful 👍

  Marked as helpful

  0

  ---

  

  Amr•710

  @amrmabdelazeemPosted 12 months ago

  @Zy8712 Thank you for your response! I'll replace the semantic tags with divs, I also known I can use absolute and add the parent to relative but I don't know how I missed it!

  Also seems like I missed adding brains to the dice to change the adivce and only left it to refreshing the page, will be working on that very soon.

  0