Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App via the Advice Slip API

@fmanjencic

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am welcome to any feedback or constructive criticism!

Community feedback

Frieden 260

@Amanmawar17

Posted

Hello, Hope you doing well. In your submission, there is a minor problem your button is a dice icon and it should be the whole button with padding. The classes you give to class imgbox it should be given to the button not to div then it works well. Right now, when I click on the icon then it fetches the advice. Second, Your body should have height of 100vh then apply classes of flex, justify center, items center so your container comes in center.

Thank You.

0
Aimal Khan 2,260

@Aimal-125

Posted

Bro in your css code, increase the height of body element to 120 or 150vh by using media query with max-height: 400px; So that it looks good on small heighted screens as mine (samsung j3). Otherwise your solution is looking perfect!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord