Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator app

Breia 50

@BreiaJohn

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@katjadanilova

Posted

Hey!

I have a few suggestions that you might find useful:

  1. your picture element is outside the container, although it should rather be inside, and only button (in your case) to be position: absolute.
  2. Accessibility report requires buttons to have a label. So, in this case, it might be better to opt in for a div that has an img inside it, with alt text that would describe the action.
  3. Accessibility report also wants you to have a main tag inside your body instead of a div.

Please let me know if my suggestions aren't helpful :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord