Submitted about 1 year ago
Advice generator app using VSC, next.js, react, tailwind.
@VillageR88
Design comparison
SolutionDesign
Solution retrospective
Hello my name is Karol and I'm currently learning frontend development.
Community feedback
- @FluffyKasPosted about 1 year ago
Hey Karol,
Looks like a good solution. There are only 2 things I'd mention:
- For interactions, always choose native interactive elements, inputs elements for inputs, a tags for links, and in this case, a button for making the API call.
- This is a small thing but in cases like this, instead of giving your card 2 different widths, it might be easier to define just one max-width. This way you could avoid that width-jump at 768px.
Overall great job though, well done.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord