Advice generator app using Vite.js/React/Tailwindcss/Axios

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div id="root"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  C H A R A N 🎯•2,670

  @0xabdulPosted over 1 year ago

  Hello there ! 👋 Congratulations you finished the Advice generated App...🎉

  • Some suggestions for you improve your code🤔

  Html 🏷️:

  • for Accessibility reports using the non-semantic elements (or) semantic elements..
  • semantic elements : <aside> , <artical> , <main>, <header> ,<section><footer>, <form> ect..
  • non- semantic elements : <div> , <span> ect ...
  • in fact using the h1 , h2 ,h3 ,h4 , h5 , ,h6tags should be use ❗ Ordering..
  • for easy way to clear the Accessibility reports using non semantic elements Ex :

  <div class="container" role="main">
  //Whole html code wraping the div tag named "container"..📍
  </div>
  

  • Any way using the img tag should be put the alt Attribute✅ and mention the alt discription Ex : <img src="logo.jpg" alt="logo"></img>
  • I Hope it's useful for you and wating for your next project ❤️
  • Happy Coding 😃

  0