Advice Generator APP using SASS, JS, and API

Community feedback

• 

  Allan Kirui•210

  @AllanKiruiPosted over 2 years ago

  Hi, David. Great work in completing the challenge 👏 Not many people who started it have managed to complete it.

  So I've skimmed through your code and the reason the project doesn't seem centered vertically in comparison to the design is because you have the following line of code; height: 100rem as part of the styles for the .main class. I'd suggest changing it to use the vh unit i.e, height: 100vh.

  I'd also suggest you use the colors provided in the style-guide.md file that comes included in the project files. And for this and future projects, you could also use a color contrast checker to make sure your sites meet web accessibility standards. You could watch this video on accessible color standards to learn more.

  The last thing I'd suggest is adding a Readme file to the project describing what this and any other future projects you might have are all about. This might also come in handy for visitors of your Github page 😉 #NeverStopCoding✌️

  Marked as helpful

  0

  ---

  

  David•8,000

  @DavidMorgadePosted over 2 years ago

  @AllanKirui Thanks for the feedback man! gonna try using vh for the next time instead of rems and taking more care about the colors I use.

  0