Advice Generator App using Sass

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey! It looks good!... You have accessibility issues that need to fix.

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

  <footer>
     <div class="attribution">
        //...
     </div>
  </footer>
  

  • Buttons must have the discernible text, So don't leave the alt attribute empty when using the image <img> inside the button <button> without text.

    <button class="change">
         <img src="./images/icon-dice.svg" alt="Advice Generator">
    </button>
    

    Or set the attribute aria-label to describe the button.

  Hope this help!... Keep coding👍

  Marked as helpful

  0