Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice generator app using Sass

@SaidAoussar

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Finally using some js in this challenges. Any feedback will be appreciated

Community feedback

T
Chamu 13,110

@ChamuMutezva

Posted

Greetings Said

Nice work so far. Here are a few suggestions:

  • use semantic elements always. Click events should be associated with elements such as a button so that they can be accessible. A div used for interactive purposes , will need require a lot more coding for it to be accessible.
  • on small devices , add some margin-inline on the main element to maintain a space between the body and the card

Marked as helpful

1

@SaidAoussar

Posted

@ChamuMutezva Thank you so much. Good advice i well change div to button. i dont get the second advice.

0

@Kamasah-Dickson

Posted

Your solution looks great on smaller devices but one thing that I will say is for you to add a rotation to the button when clicked, also when There is an error fetching data due to the bad internet It should prompt the user there was an error.

There is also sometimes a delay on fetching the data. There can be a message saying please wait

Besides good job there happy coding👍👍

Marked as helpful

1

@SaidAoussar

Posted

@Kamasah-Dickson Thanks you so much, i well try to add spinner for fetching and message for errors.

0

@Kamasah-Dickson

Posted

@SaidAoussar okay happy coding👍💻

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord