Advice generator app using Sass

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings Said

  Nice work so far. Here are a few suggestions:

  • use semantic elements always. Click events should be associated with elements such as a button so that they can be accessible. A div used for interactive purposes , will need require a lot more coding for it to be accessible.
  • on small devices , add some margin-inline on the main element to maintain a space between the body and the card

  Marked as helpful

  1

  ---

  

  Said Aoussar•130

  @SaidAoussarPosted over 2 years ago

  @ChamuMutezva Thank you so much. Good advice i well change div to button. i dont get the second advice.

  0
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted over 2 years ago

  Your solution looks great on smaller devices but one thing that I will say is for you to add a rotation to the button when clicked, also when There is an error fetching data due to the bad internet It should prompt the user there was an error.

  There is also sometimes a delay on fetching the data. There can be a message saying please wait

  Besides good job there happy coding👍👍

  Marked as helpful

  1

  ---

  

  Said Aoussar•130

  @SaidAoussarPosted over 2 years ago

  @Kamasah-Dickson Thanks you so much, i well try to add spinner for fetching and message for errors.

  0

  

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted over 2 years ago

  @SaidAoussar okay happy coding👍💻

  0