Advice generator app using React and Sass

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi MD5, have you tried using AbortController instead? I think a timeout can be set; I've seen a Log Rocket article on comparing fetch with axios, and it seemed like a possible option.

  Also, for the width of the advice box, I tried resizing the browser to a smaller width and noticed that the component wasn't too responsive. I couldn't quite figure out what was going on, but I did wonder whether it's due to the absolute positioning, so I tried removing all the properties for absolute position and then added flexbox for centering with a responsive width, like this:

  main {
     display: flex;
     align-items: center;
     min-height: 100vh;
  }
  

  I only chose main since that seems to be the child node of the root div, but I'd suggest creating a parent container div for main and setting these rules there instead. Anyway, this seems to help with centering and with keeping the component responsive, so you can see whether you'd want to try this out too.

  Marked as helpful

  0

  ---

  

  Md5 dalton•1,430

  @md5daltonPosted over 2 years ago

  @elaineleung thanks for the catch👍

  1