Advice Generator App Using Html , Css ,Javascript and Advice Slip JSON

Community feedback

• 

  Tobenna•610

  @tobezhanabiPosted over 1 year ago

  Hi Pavan, You did a nice job working with an API. Congratulation on submitting a working task. 🎉🎉

  Here are a few suggestions to the issue with your solution.

  Work on HTML The landmark <main class="container"> should not be a child to <section class="background" >. Landmarks in HTML are structural elements that define the major sections of a webpage. They include semantic elements such as <header>, <nav>, <main>, <article>, <aside>, and <footer>

  Heading You left the h1 tag empty, maybe you forgot to put the advice numbers there.

  Add slip.id from the API to take in the Advice's numbers and display it.

  Others

  • You should make your dice button glow when its hovered on and change the cursor to pointer... Like so:

    .circle:hover {
  cursor: pointer;
  box-shadow: 0px 0px 20px 0px rgba(82, 255, 168, 1);
  }
  

  Hope you find this helpful

  Happy Coding😀

  0