Advice Generator App using HTML, CSS, and basic JS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Ronald, You have done a good work! 😁

  Some little tips to improve your code:

  • add margin: 0 to body to remove the side scrool bar of browser
  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article or blockquote tag instead of a simple div to the container card for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • remove all margin from main tag because with flex they are superfluous
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • if you need only style an element use class and not a id because id must be unique in the all page of document

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Ronald Sayre•260

  @RJ3605Posted almost 2 years ago

  @denielden Hi Deniel, I appreciate the feedback! I went back and modified the code with most of your suggestions, and I am happy with the result. I did not know about the article or blockquote tags, so thank you very much for that!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @RJ3605 you are welcome and keep it up :)

  1