Advice generator app using fetch

Community feedback

• 

  dgjenni2•320

  @dgjenni2Posted about 2 years ago

  Nice, simple solution. The fetch looks good, except I'd remove the console.log() statement before the final commit so that you don't log backend information to the console. I might also try to use a single .then() to handle the response rather than chaining two together, but nothing technically wrong with how you implemented it.

  On the css, I would recommend using classes and using tag selectors more than just ids. While ids do work on a smaller project like this, class and tag selectors can apply more broadly and be reusable between components. Also, really would try to avoid the hard coded pixel heights and widths in the css and use REM or EM units instead.

  Overall, nice work and keep at it!

  Marked as helpful

  1

  ---

  

  shikoto•1,010

  @shikot0Posted about 2 years ago

  @dgjenni2 Thanks for the feedback

  1