Advice Generator App using fetch API and async await functions

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings aproskur. Well done , so far so good. Here are a few recommendations :

  • since these are quotes, i would suggest using blockquote element instead of a div.
  • using fixed width like width: 350px for the advice card will prevent the card to be responsive on small devices under a width of 350px and less. Using max-width might help as that will only make sure that the card does not exceed the mentioned size but at the same time allow the card to scale done on small devices.

  Marked as helpful

  0

  ---

  

  Anna•190

  @aproskurPosted over 2 years ago

  @ChamuMutezva hi Chamu, thank you for your feedback, I absolutely agree regarding responsiveness and have already corrected the widths. I am not quite sure about blockquotes, as in this case <blockquote> tag might be redundant as the quoted text is quite short, <q> is not also required as there is no other surrounding text here on this card. I tried to check if it is a "must" requirement for accessibility, but in this particular case it seem ok not using it, anyway I have checked this tag out too. But I agree a pure div there was not fine, at list a <p> tag should be added there

  0
• 

  Ivo•240

  @ivcpPosted over 2 years ago

  Nice! Also, I would set the cursor to pointer on the dice button

  0

  ---

  

  Anna•190

  @aproskurPosted over 2 years ago

  @ivcp Thanks, mate. sure, will add that :)

  0