advice generator app using api

Community feedback

• 

  hamza•390

  @HamzaouladevPosted over 1 year ago

  Hello Bianca, i have some feedback regarding your layout that you may find interesting:

  -usually its not a good idea to give your components a fixed height, because then the component wont be able to dynamically adjust to large amounts of contents or small screens and you may run into overflowing issues, its best to let your component's height be determined by its content.

  -in terms of width you can make your components fully responsive using only two lines of code and no media queries, you can use the following hack:

  main {
     width: 90%;
     max-width: 560px;
  }
  

  -my suggestion for managing spacing is to use a simple technique called The lobotomized owl selector

  -and i would also sugegst using absolute positioning for the button, so it wont be relied on its siblings for its position.

  i hope you found my feedddback helpful, Happy Hacking

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  ---

  • This solution has generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every page must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0