Advice generator app using Advice Slip JSON API, Tailwind CSS and JS

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi Alejandra, great job putting this together! 🙂

  First off, there's quite a number of HTML issues here...! I looked at some of the issues listed, and I think it may have to do with the CDN file you used for Tailwind, as there's no tree shaking of styles you didn't use. I don't know whether you'd want to fix those issues, but in case you do, you can try using Beyond Code's JIT CDN file for Tailwind instead: https://unpkg.com/tailwindcss-jit-cdn

  Also I found that I'm not able to retrieve the next advice after the first one loaded, which is a common issue on Firefox due to caching. You can test it out yourself too if you have Firefox. To fix it, simply add a line for cache in the header object for fetch:

  fetch("https://api.adviceslip.com/advice", { cache: 'no-cache' })
  

  Well done overall!

  Marked as helpful

  0

  ---

  

  Alejandra Monroy•90

  @alesamvPosted over 2 years ago

  @elaineleung Thank you for your comments, I hadn't realized what was happening in firefox, but you helped me to solve it.

  1
• 

  Obieze Ezeugo Felistus•130

  @FelistusPosted over 2 years ago

  Hello Monroy! Nice attempt. But you need to check the font size on mobile screens. The texts seem to be competing with each other on small screens and as such, make the design look poor. The font size of the texts should adjust based on the screen size or you assign a fixed font size for mobile screens using px.

  0