Advice Generator App Using Advice Slip API

Community feedback

• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of h1 to be more semantic
  • increase the width of the container because it is so small compared to the design try 500px for example
  • on small screens decrease the font size of the quote to 20px

  hope this is helpful

  Marked as helpful

  0

  ---

  

  sansarj17•180

  @sansarj17Posted over 2 years ago

  @Old1337 I am starting with the semantic html and didnt knew about it, Thanks. The sizing was looking a bit too big on my screen (~1234px) and seeing ti developer tools do make a big difference. However thanks for the advice, i will take it into account.

  1