Advice generator app

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Awesome work with this challenge. Looking at your solution, I think you should know the following as well…

  • Instead of div, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. For example, this line here <div class="container"> could be wrap with main tag
  • The HTML structure is well organized and clean
  • Well done in implementing the API, the main button generates random advice when click. There is also the hover state design which you add properly
  • The project itself is responsive and the details was utilized based on the original design
  • Well done with the styling, the CSS file is looking great and neat
  • JS functionality is well implemented. Just for curiosity, what about this line "use strict"; ?

  Advice #98

  "It's always the quiet ones."

  Above all, the project is well implemented. Keep up the good work!

  Marked as helpful

  1

  ---

  

  Alexis David•260

  @amendezmPosted over 2 years ago

  @RioCantre thanks a lot for you feedback! Agree with you about semantic tags.

  https://www.w3schools.com/js/js_strict.asp.

  0