Submitted over 2 years ago
Advice Generator APP + translate function | HTML CSS JS
@Carlosgnx
Design comparison
SolutionDesign
Solution retrospective
i liked this project, i added an extra function to translate the advices generated by the app. your feedback is appreciated!
Community feedback
- @CyrusKabirPosted over 2 years ago
Hello my dear friend, you did a good job on this project and I liked your advice translating idea. and here some tips and improvements for your code and component :
- add your advice to a <q> tag.the q tag use case it's for short quotation and browsers normally insert quotation marks around the quotation. you can read more about q tag in html HTML q tag
- your dice icon for button it's not loaded because you should use
./
in url not/
you can read more about this in this link - try to use
addEventListener
for more readable code and other things which you can find them in this stackoverflow post why are inline events bad
Marked as helpful1@CarlosgnxPosted over 2 years ago@CyrusKabir thank you!, definitely i will apply your advices.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord