Advice generator app

Community feedback

• 

  Arne•1,110

  @DudeldupsPosted 3 months ago

  Hello!

  Your solution looks good, there's just one small flaw with the divider. Always look at your result with the dev tools of your browser (or better more than one browser). If you set the viewport to 320 px (that's the smallest viewport you should take into account when laying out the website) the divider is breaking out of the card.

  Do not use px to declare font-related sizes. This is crucial for accessibility. If a user sets a custom font-size in their browser and you use rem or em, their font-size will also change accordingly.

  Headings should always be in descending order. There's no reason to use <h6> since there is no other heading on the site. Don't use heading levels just because they "look like that heading".

  And here's an article about the alt attribute, the divider should have an empty alt attribute, since it does not add to the info on the page. It's just a decoration item. https://www.w3.org/WAI/tutorials/images/decision-tree/

  Please take the time to go through your solution and try to improve it. As a small tip, you can visit the challenge hub after you completed a challenge and look at other ppl's solutions. Look for some that have comments on them and see if someone gave feedback to that person, there's a high chance that you can also learn from that 🙂

  Hope this helps, happy coding 👾

  Marked as helpful

  0

  ---

  

  Nahin Moreira•240

  @nahinMSMPosted 3 months ago

  @Dudeldups Espero que ajude, boa codificação 👾 Ajudou muito, obrigado!

  0