Advice generator app

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Plinsinga, great work here, and I like what you did with the animating dice icon! I know what you mean about using the initial advice in the design in order to have the pixel perfect screen shot because that's what I did, and I only changed it to have a loading animation afterwards 🙂

  About the API, right now I see an issue when I'm viewing this on Firefox where the advice doesn't load on the second round, and this is most likely due to caching. You can try this on Firefox if you have it, and to fix it, you can try adding a header object in fetch:

  fetch("https://api.adviceslip.com/advice", { cache: 'no-cache' })
  

  By the way, great job in adding an error handler with fetch! One last suggestion is, since you only have pure text from the data and don't need to parse HTML, try to use textContent instead of innerHTML.

  Marked as helpful

  1

  ---

  

  Plinsinga•310

  @codedforfreePosted about 2 years ago

  @elaineleung thank you for your advice. This is really helpful to get to know more about api calls! Will fix the Firefox error asap.

  Thanx!

  1