Advice generator app

Community feedback

• 

  Zhiul•220

  @ZhiulPosted almost 2 years ago

  Hi! It is looking great. There are some quick fixes or things that you could improve :)

  1. You could use rem to make it more accessible.

  2. When it comes to your .advice-content__button, you could create it with a <button> or at least use role="button".

  3. When it comes to the transitions, try to narrow the transitions only to what is needed to transition, sometimes using all could be ok, but, here some unnecesary transitions could happen (e.g: when resizing the browser and so on, sometimes they can look strange, so I suggest you to be more aware of transitioning only what is needed)

  Marked as helpful

  0