Advice Generator App

Community feedback

• 

  Hikmah•1,070

  @HikmahxPosted almost 2 years ago

  Hi Ruthwik. Great solution. I'd like to suggest for the error above involving a button: <button class="btn--advice"><span class="icon--advice"></span></button>. To resolve this, you can add an aria label into the button like: <button class="btn--advice" aria-label="generate another advice"><span class="icon--advice"></span></button>. For the other issues of landmarks, you can change the div with the class of box-wrapper to a main tag.

  Marked as helpful

  0

  ---

  

  Ruthwik•190

  @web-deviePosted almost 2 years ago

  @Hikmahx , Thanks a ton Hikmah for helping me out with the accessibility, I am confused how to manage them and thanks for clearing that out for me. Have a great day!

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Ruthwik, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • use article or blockquote tag instead of a simple div to the container card for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  Ruthwik•190

  @web-deviePosted almost 2 years ago

  @denielden Thank you so much Deniel, those are some really awesome insights. Also, thanks for citing the resources as well. I will definitely use them to improve my code. If you don't mind can you tell me where I can reach you( if that's okay for you), since I'm a newbie I would like to seek help from you and grow :)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @web-devie You are welcome and keep it up :)

  Of course, you can write to me through the form on my site (you can find the link to the site on my profile)

  Marked as helpful

  0