Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App - (HTML, SASS, JS, API)

@johnphillipsdev

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@Kamlesh0007

Posted

Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further.

<p class="advice-value">Advice <span id="index">#117</span></p>

And make this .advice-value class as h1 tag not p tag because By replacing the <p> tag with an <h1> tag, you ensure that the content within the .advice-value element is treated as a heading rather than regular text. This change aligns with the semantic structure of the HTML document, where headings (<h1> to <h6>) are used to denote hierarchical levels of importance and structure and also add the "#" symbol before the 'Advice' heading, you can modify the code as follows: document.getElementById('index').innerHTML = `Advice #id`

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord