Advice Generator App | HTML CSS JS API VisualStudioCode

Community feedback

• 

  suroh•80

  @m3astwoodPosted over 1 year ago

  Hi Enrico,

  I had this issue in Firefox also. In your fetch request add in cache: 'no-cache' as an option. Code snippet below :

  ...
  fetch('https://api.adviceslip.com/advice',  { cache: 'no-cache' })
  ...
  

  Details can be found here

  Hope this helps!

  Marked as helpful

  0

  ---

  

  Enrico Colombini•180

  @Enrico-BarrosPosted over 1 year ago

  @m3astwood Thank you so much!! That also solved the loading problem between advices

  0

  

  suroh•80

  @m3astwoodPosted over 1 year ago

  @Enrico-Barros my pleasure!

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  congratulations on completing the challenge!🎉. That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. I noticed that your app can take some time to load, and it might be a good idea to add a loader to improve the user experience. You can add a loader while fetching data from an API, you can follow these steps: add this code in ur javascript with css of loader in ur stylesheet

  const loader = document.getElementById('loader');
  
  function showLoader() {
  loader.style.display = 'block';
  }
  
  function hideLoader() {
  loader.style.display = 'none';
  }
  
  // Example of fetching data from an API
  function GetAdvice(){
  showLoader();
  fetch('https://api.adviceslip.com/advice')
  .then ((response) => {
  return response.json();
  })
  .then ((json) => {
  hideLoader()
  const advNum = json.slip.id;
  const adv = json.slip.advice;
  
  number.innerText = advNum;
  advice.innerText = adv;
  })
  .catch(error => {
  console.log(error);
  })
  }
  

  Marked as helpful

  0