Advice generator app fetch async js

Community feedback

• 

  Zineb Boutaa•750

  @zineb-BouPosted over 2 years ago

  Hi there, your solution looks good I am dropping some suggestions that may help you to improve your code even further.

  1- Concerning the images, since they are for decoration don't keep them visible for the screen reader(we don't need it to read their source path).

  2-The advice text instead of putting inside a <div> it's better to put inside a <p> tag.

  3-Add an aria-label=" generate advice", to make the button readable by the screen reader.

  Happy coding :)

  Marked as helpful

  0
• Account deleted

  Hi there,

  • add text-align:center; to the advice div
  • put the quote inside a <blockquote> tag instead of div to be more semantic
  • Check the HTML report to fix accesibility issues

  i hope this is helpful and goodluck

  Marked as helpful

  0