Random Advice Generator

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  • There isn't much information about what the button is for, and dice icon as the alt attribute value is not very descriptive, screen reader users will hear "Button, dice icon" and they won't understand what the button does. You can use Generate new advice as the alt attribute value. You can see an example here.

  • Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the text-transform property to transform the text to uppercase in CSS.

  • You should use the cursor: pointer property to indicate that the element like a button or a link is clickable.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Jacek•110

  @Jacked-99Posted almost 2 years ago

  @MelvinAguilar
  Thank you for your feedback. 😊 I've added all of your suggestions into my solution.

  0