Skip to content
Submitted about 1 month ago

Advice Generator App Challenge Solution

Dahmide•70
@dahmide
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud of my experience during the challenge and how I handled the initial loading of the advice generator app by adding a skeleton loader. I am also glad that I was able to address the user stories for the challenge.

Looking ahead, I would like to write cleaner code, speed up my workflow, and make my work perform better and be more accessible.

What challenges did you encounter, and how did you overcome them?

I did not face any major troubles in completing the challenge, as I was able to check off the user stories for the challenge, and also stayed on time.

Note: Once the design comparison is adjusted, this line will be removed.

What specific areas of your project would you like help with?

I would appreciate some feedback and code review on the overall challenge.

Community feedback

  • Mahmood•1,510
    @MahmoodHashemPosted about 1 month ago

    Great, I checked all your code, very clean and readable, awesome.

    However, I couldn't figure out how you implemented the skeleton. There was no mention of the skeleton in the JavaScript code, and I didn't see any functionality to toggle it or interact with it when data is fetched.

    0
    Dahmide•70
    @dahmidePosted about 1 month ago

    @MahmoodHashem Thanks for your feedback. Much appreciated.

    The skeleton loader was implemented in CSS. Since the JavaScript injects the text content, the loader elements are removed.

    1
    Mahmood•1,510
    @MahmoodHashemPosted about 1 month ago

    @dahmide Ok, Got it. Thanks

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord