Skip to content
Submitted over 2 years ago

Advice Generator App Challenge

Abizahir Romero•30
@AbizahirR
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

This was my frist time employing an API on a project, it's too cool how it works.

Feedback welcome, better practices, etc.

Community feedback

  • Stijn•460
    @stijnmeershoekPosted over 2 years ago

    it's a very small thing, but I always consider it best practice to use .textContent and not .innerHTML for adding text to an element. for this project it's not really that important but innerHTML is a security problem and could be used by hackers if used wrongly.

    Marked as helpful
    1
    Abizahir Romero•30
    @AbizahirRPosted over 2 years ago

    @ROGU3N1NJA Thanks for your fb, i'll start use .textContent on my next projects.

    0
    Stijn•460
    @stijnmeershoekPosted over 2 years ago

    @AbizahirR You're welcome

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord