advice Generator App built with React Js

Community feedback

• 

  P

  Kent O'Sullivan•1,870

  @12KentosPosted over 2 years ago

  Hey @obinneji,

  Nice job on this project, it looks great! I looked through your code and noticed for the mobile section you added the following code to your media query.

  height: 90vh;

  Was there a reason for doing this? If you remove this line of code, it immediately looks a lot better. Generally in most cases, it's better to let the content create it's own height rather than setting a fixed one.

  Hope this helps, and keep up the great work!

  Marked as helpful

  0

  ---

  

  Obinneji Chibuzor Francis•270

  @obinnejiPosted over 2 years ago

  @12Kentos if the words in the advice are much it tends to display over the main container, especially in mobile view, that was why I extended the height to 90vh for mobile.

  0