Abdul Khaliq 🚀• 72,680
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of
semanticmarkup, which causes lacking of landmark for a webpage
- So fix it by replacing the
<figure>element with the semantic element<main>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, the
<main>element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0
Arby• 170
@mobalti
Posted
Hello @0xAbdulKhalid , I have fixed the problem. However, I believe that the main tag may not be the most appropriate tag to represent this content, especially considering that there are no other sections in the app. Nonetheless, thank you for your help in identifying the issue! 👍
0
