Advice generator app

Community feedback

• 

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  Hi, @Afrid-Ahamed

  I've got a few recommendations for you to improve -

  • Start using Modern CSS Reset rules so you don't need manual reset. Just take the code from there.

  • Start using HTML5 Semantic Elements like <header>, <main>, <section>, etc. with HTML Accessibility rules.

  • For the pattern divider image you can provide alt="" empty. alt="pattern-divider-desktop" doesn't imply anything to screen readers. Provide alt="" with some values for main content-related images. For icons, we can keep it empty.

  However, the solution looks great. Good job! Hope this help you to improve.

  Happy Coding

  0

  ---

  

  Afrid Ahamed•40

  @Afrid-AhamedPosted 12 months ago

  Hi @KrishnaVishwakarma1595,

  Firstly, Sorry for the delayed response...

  Thank you for your valuable feedback. Will incorporate the same moving further.

  0