Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
- Use the
<main>tag to wrap all the main content of the page instead of the<div>tag. With this semantic element you can improve the accessibility of your page even though this challenge is not a full page.
- Since I can currently spam it with clicks, it would be better if you added a delay of for example 2 seconds. This would mean the user cannot click on the button.
- There isn't much information about what the button does, and using "dice-icon" as the image alt text does not convey anything. Screen readers actually read it as "dice-icon, button". You can use "Generate new Advice" as an alternative text to the image in order to describe it more accurately.
Here is a resource to help you with alt text.
Also, if you want to learn more about the alt attribute, you can read this article.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding! 🎄**
Marked as helpful
1
