Advice generator app 🎯

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  body {
  justify-content-center;
  align-items: center;
  }
  
  footer {
  position: fixed;
  bottom: 1rem;
  }
  

  • We additionally placed used fixed positioning for the footer to place that in the bottom of the site properly.

  ---

  • Now remove these styles, after removing you can able to see the changes

  main {
  margin: auto auto 0;
  }
  .footer {
  margin-top: auto;
  }
  

  ---

  ---

  • Now your components has been properly placed at the right position.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Alamin•2,000

  @CodeWithAlaminPosted over 1 year ago

  @0xAbdulKhalid Thanks, I'll check that soon 😊

  0