Advice Generator App with JS CSS and HTML

Community feedback

• 

  Dytoma•550

  @DytomaPosted almost 2 years ago

  Hey, Good job on completing this challenge however I do have some recommendations for accessibility:

  • First I'll suggest you add an aria-label attribute to your button as there is no text to describe the button and an aria-hidden="true" to the image inside the button for screen readers to escape this element. <button id="randomAdvice" aria-label="new advice"><img src="./images/icon-dice.svg" alt="Dice" srcset="" aria-hidden="true"></button> .

  You can read more about ARIA :

  • MDN ARIA

  Marked as helpful

  1