Advice generator app

Community feedback

• 

  cacosted•570

  @cacostedPosted over 2 years ago

  Hello @PabloRodrz your solution looks very great, the loading part is a nice touch. Doing some testing I noticed that the "advices" div has a height and width set with percentage(%). This could bring some issues. I suggest that you add a "max-width" along side the width to handle better the maximum horizontal size. And with the height, is better is you replace the height with min-height, because if the content inside is larger the height that you set the content won't be shown

  Marked as helpful

  0

  ---

  

  Pablo•100

  @PabloRodrzPosted over 2 years ago

  Hello mate! @cacosted Which max-width and min-heigth would you recommend to use in this case? By the way, thank you so much for reviewing my code!

  0

  

  cacosted•570

  @cacostedPosted over 2 years ago

  @PabloRodrz With the max-width I recommend you to use a more consistent unit like px or rem in this way the box will grow until it reaches that size. And with the min-height the same thing but you don't need to set a height because the box will grow with the content.

  Marked as helpful

  0

  

  Pablo•100

  @PabloRodrzPosted over 2 years ago

  @cacosted I just updated the CSS file! Could you check it? :) I think that I got what you just said

  0