Advice generator using Grid

Community feedback

• 

  Dytoma•550

  @DytomaPosted almost 2 years ago

  Hey👋

  Good job on completing this challenge👏 the animation on the advices looks amazing

  I have some suggestions you might want to implement to improve your code:

  • First you don't need the <header></header> and the <footer></footer> elements as they have empty content thus useless to your code and you could also put your h1 in the main element.
  • For your button, I suggest you give it an aria-label="new advice" and to the image an aria-hidden="true" as the image just serves for decoration. You cam learn more about ARIA.

  Happy coding👏

  1
• 

  adr99•410

  @leorichy99Posted almost 2 years ago

  Great job @Zosima..

  I just think you could add some transitions to the button that generates the advices.

  Happy coding👏

  0