Advice Generator App

Community feedback

• 

  P

  Grant Ramsay•280

  @seapaganPosted over 2 years ago

  Looks great, well done :)

  One thing to look out for is that you would not see new advice in Firefox, and the button seems to do nothing because Firefox caches the response. To fix this, add {cache: 'no-store'} to your fetch command like so :

  fetch("https://api.adviceslip.com/advice",{cache: 'no-store'})
  

  Also, perhaps remove the original placeholder text from your HTML in the 'advice' h2?- On the first load, you sometimes see a flash of the placeholder before the API returns the new Advice fragment. You can't leave H2 empty, though, as it may be tagged in the report; maybe put a space or a period?

  Marked as helpful

  0

  ---

  

  Sam•230

  @samd1aPosted over 2 years ago

  @seapagan Thank you so much!

  0